Bug #366

potential (small) bug in SolarRadiationPressure

Added by Pascal Parraud about 1 year ago. Updated 5 months ago.

Status:ClosedStart date:2017-10-12
Priority:NormalDue date:
Assignee:-% Done:


Target version:-


In the SolarRadiationPressure class, the getFieldEventsDetectors method returns an empty Stream while the getEventsDetectors method returns a Stream with 2 event detectors, it seems weird.


#1 Updated by Luc Maisonobe 6 months ago

Looking at this, it is not as easy to solve as it first seemed :-(

We would need either a FieldPVCoordinatesProvider for the Sun, which is impractical
because the filed type T should be fixed in the attribute, but the type is variable
as it is an argument to getFieldEventsDetectors, or we should change the type of
the Sun attribute to CelestialBody, which is an incompatible change (but probably a
safe one).

#2 Updated by Luc Maisonobe 6 months ago

I have created issue #470 to track the need for a more general change.

#3 Updated by Luc Maisonobe 6 months ago

  • Status changed from New to Resolved

Fixed in git repository (see ff80c506).

It was in fact possible to introduce an intermediate interface between PVCoordinatesProvider
and CelestialBody. This allowed to use the Sun provider to provide both versions of the
coordinates (double and field) at once.

#4 Updated by Luc Maisonobe 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF