[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orekit Developers] protected constructors in DifferentialOrbitConverter



Paul Cefola <paulcefo@buffalo.edu> a écrit :

Luc,

Hi Paul,


Do I need to think about cloning the Orekit project again to capture the latest updates?

There is no need to clone again for getting the updates. Using eclipse and its Egit plugin, you can update your current code base. In order to do this, right-click on the package explorer at the orekit project entry in the tree to get the context menu, and select Team->pull. This "pull" command fetches the new code from the repository and merge it with your currnt code. IF you have done local changes, the commands do its best to merge both your local changes and the remote changes that are fetched. If the same file has been changed around the same lines in both versions, the conflict is detected and a warning is displayed. If the local changes and the fetched changes are far away, Git merges everything smoothly. You can also run the fetch command from the command line if you prefer (running "git pull" in the orekit top directory).

best regards,
Luc

There have been no changes recently on the DSST part, so you may keep the current version you have if you want.


Paul

Dr. Paul J. Cefola
Adjunct Professor, Dept. Of Mechanical and Aerospace Engineering, University at Buffalo (SUNY)
Consultant in Aerospace Systems, Spaceflight Mechanics,&  Astrodynamics
508-696-1884 (Vineyard Haven MA home phone)
978-201-1393 (cell)

paulcefo@buffalo.edu
paul.cefola@gmail.com


On 6/17/2012 1:06 PM, MAISONOBE Luc wrote:
Petrus Hyvönen <petrus.hyvonen@gmail.com> a écrit :

Hi,

Hi Petrus,


I'm trying to get the TLE adaption working through my python wrapper, but came to some confused state.

Why is the DifferentialOrbitConverter constructor and method declared as protected (and not public)? I'm trying to access these externally, but this is maybe not the envisioned usage? I do not see in the unit test example that they are inherited, but the unit test is declared in the same package so it can access it directly.

I think it is a mistake, the constructor was probably copied from the base class before being modified. The same issue was is the LevenbergMarquardtOrbitConverter.

I have fixed this in the Git repository.

thank you for the report

best regards,
Luc


Best Regards
/Petrus





----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.








----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.